GU44 group members window broken

tknarr · #1 03-22-2008, 09:21 PM

The default vertical group member window got broken with the GU44 changes. Member 1 looks OK, member 2 is definitely missing a few things. I'm working on the XML now, and should be able to post a diff with the corrections once I'm done.

tknarr · #2 03-22-2008, 09:41 PM

OK, apparently member 2 is missing the line for the health bar, and member 3 has an extra line "Indicator" that's not on any of the others. Also, member 1's "MemberInfoPage" page tag has more complicated OnHide and OnShow attributes referring to group member 0. Members 2-5 don't have that, not sure if that's a glitch or correct. Attached is a diff of the eq2ui_mainhud_groupmembers.xml file showing the changes I made.

dragowulf · #3 03-22-2008, 09:43 PM

Quote:

Originally Posted by tknarr

OK, apparently member 2 is missing the line for the health bar, and member 3 has an extra line "Indicator" that's not on any of the others. Also, member 1's "MemberInfoPage" page tag has more complicated OnHide and OnShow attributes referring to group member 0. Members 2-5 don't have that, not sure if that's a glitch or correct. Attached is a diff of the eq2ui_mainhud_groupmembers.xml file showing the changes I made.

Unfortunately I believe gm9 is on a two-week vacation (starting today I believe), so I don't think he could get to fix any of these.

tknarr · #4 03-22-2008, 10:01 PM

Other problem I noticed that I think is keeping the cure buttons from looking right when an effect's active to be cured is that some OnShow and OnHide attributes are missing line markers in their text. Attached is the diff.

tknarr · #5 03-22-2008, 10:03 PM

Quote:

Originally Posted by dragowulf

Unfortunately I believe gm9 is on a two-week vacation (starting today I believe), so I don't think he could get to fix any of these.

Well, my diffs will be here when he gets back, I suppose, assuming nobody else can upload fixes to the updater. I've gotta fix the thing anyway, might as well have what I found/did visible.

Drunador · #6 03-22-2008, 11:14 PM

Ok, I very much appreciate you finding a bug and trying to fix it. I love ProfitUI.
But here is my problem. I can not tell where in the original file your fix goes, and your txt file has @ symbols in its text that gm9's does not. Could you not just attach a fixed version of the file in question?

I don't mind cutting and pasting if it is obvious where to do such.

Drunador

Kaldran · #7 03-23-2008, 06:10 AM

Obviously I have access to the files on the updater. I'll check in your diffs once I am sure they do not break anything. Will take some days though since I am not at home...

**gm9** · #8 03-23-2008, 06:16 AM

I caught the issue on the way out, so fix should be on the updater (not sure what was wrong with OnShow/OnHide though, that's not fixed if it was really broken, I don't have the time to look into that now). Also the manual download was the same file as 4.6a. Doh, I really need that vacation!

I'm gone for good now, so if anything else comes up post a fix and let Kaldran know. As long as the updater isn't pushing Fetish Nightfall when I'm back I'm ok with that.

tknarr · #9 03-23-2008, 01:23 PM

Quote:

Originally Posted by Drunador

Ok, I very much appreciate you finding a bug and trying to fix it. I love ProfitUI.
But here is my problem. I can not tell where in the original file your fix goes, and your txt file has @ symbols in its text that gm9's does not. Could you not just attach a fixed version of the file in question?

I don't mind cutting and pasting if it is obvious where to do such.

Drunador

Aha. I use unified-diff format. And I'm still working on it. I've got the health-bar working, but the effect icons for everybody but member 0 are still glitched. Their normal appearance is OK, but when they light up to show there's an effect to be cured they're a white-background-only (not quite white, it looks like the normal background texture's there) square instead of the brightly-lit icon. The click-to-cure still works, I'm just trying to figure out the glitch. Attached is my version of the file.

tknarr · #10 03-23-2008, 03:12 PM

Quote:

Originally Posted by gm9

I caught the issue on the way out, so fix should be on the updater (not sure what was wrong with OnShow/OnHide though, that's not fixed if it was really broken, I don't have the time to look into that now). Also the manual download was the same file as 4.6a. Doh, I really need that vacation!

I'm gone for good now, so if anything else comes up post a fix and let Kaldran know. As long as the updater isn't pushing Fetish Nightfall when I'm back I'm ok with that.

Thanks muchly for the fix.

The OnShow/OnHide I'm not sure was a problem, it used a space to separate the different "lines" of the code in the attribute where in member 1 it was using hex-encoded CR and LF between them. It doesn't seem significant. I'm going to try your updated files and see if they're working right.

tknarr · #11 03-26-2008, 10:44 PM

Alas, still not quite. I'm at a loss to figure out what's wrong with the click-to-cure icons in the default group window. Group member 0 (self) the cure icons are fine. For group members 1-5 (others), the icons appear faint normally, but when an effect comes on that normally would cause the icon to light up bright I get a white background-texture box instead completely obscuring the icon. Clicking on a "lit" icon still causes the cure to fire off, the glitch is purely cosmetic. It's almost like the background is laying on top of the actual icon image instead of being behind it.

**lordebon** · #12 03-26-2008, 10:47 PM

Quote:

Originally Posted by gm9

As long as the updater isn't pushing Fetish Nightfall when I'm back I'm ok with that.

*Chuckles*

I think he should do that, just for gits and shiggles ((if you don't get what they are... transpose the first letters of the two words))

OwennII · #13 03-27-2008, 09:22 PM

Bump, to keep this at the top, in case anyone else can fix this.