Storyline Tab in the Journal.

[gjsi]

Not sure if the default UI has it, but told there was a checkbox on the storyline tab to hide completed storylines, I don't see this on the Profit Storyline tab, is this going to be added, or did I miss an update somewhere?

[Zlar]

Originally Posted by gjsi

Not sure if the default UI has it, but told there was a checkbox on the storyline tab to hide completed storylines, I don't see this on the Profit Storyline tab, is this going to be added, or did I miss an update somewhere?

It is not added yet. However I did manually modify my ProfitUI code to allow for it and have posted a link to it here. I hope that the powers that be will take the code and add it to their updater.

But for now if you wish to manually modify your file take this code and copy it over your existing code for "eq2ui_journals_quest.xml" located inside your ProfitUI folder.

http://mysite.verizon.net/res12s1kz/...nals_quest.xml

[Papabard]

Good file. However doing a compare its missing a lot of code compared to the one currently on the updater. Looks to be missing the search buttons area complete block and another large chunk around the top of the file. Was this a moddied profit file from recent updates or the default with stuff added in?

[Zlar]

Originally Posted by Papabard

Good file. However doing a compare its missing a lot of code compared to the one currently on the updater. Looks to be missing the search buttons area complete block and another large chunk around the top of the file. Was this a moddied profit file from recent updates or the default with stuff added in?

It is possible that it needs to be cleaned up some. What I did was take the most recent file from the updater, remove the storyline block from the xml file and replace it with the storyline block from the default ui. No other changes were made. I just did a reload of the one from the updater and do not see any features such as a search buttons on the storylines area currently. From all I can tell the changes I am using only modified the storylines so that the display box on the left was a bit shorter to allow for the checkbox to be displayed below it, like in the default ui.

[Zlar]

OK, my initial change was more a "brute force" change and did not take into consideration other areas that may have been impacted. I went into the code a little cleaner this time around and mode on the changes that were needed. You should not see at least 1 addition (might show as 1 deletion, depending on how you compare). This was the addition of the Checkbox tag for "Hide Completed Storylines". There should also be approx 10 changes. This was to address the changes in real estate to allow for the checkbox to appear at the bottom and taking away some of the space used for the listbox of storylines. I have updated the code on my web location for review. Hopefully these changes will be what it takes to get added to the updater.

[Papabard]

Just my opinion here but I much rather have a single person updating this UI at the moment that is TalTal and what I have done in the past was suggest to him changes. If the window is missing a checkbox I would ask that he put that in.

I did another compare and it seems instead of just adding the check box you're moving code way down and this is giving me a display of large blocks of text missing from the file you have and the file on the updater. The line numbers are way off so the compare displays to me as being very heavyly modified file compared to what is on the updater.

I am sure TalTal can add that check box in. If its not on the updater one can always add it as a modified version for users to choose to use over what is. This is what I did with the Persona window where I modified just the inclusion of the Spell only reuse.

[Zlar]

Originally Posted by Papabard

Just my opinion here but I much rather have a single person updating this UI at the moment that is TalTal and what I have done in the past was suggest to him changes. If the window is missing a checkbox I would ask that he put that in.

I did another compare and it seems instead of just adding the check box you're moving code way down and this is giving me a display of large blocks of text missing from the file you have and the file on the updater. The line numbers are way off so the compare displays to me as being very heavily modified file compared to what is on the updater.

I am sure TalTal can add that check box in. If its not on the updater one can always add it as a modified version for users to choose to use over what is. This is what I did with the Persona window where I modified just the inclusion of the Spell only reuse.

Hmm....not sure why it looks different for you than it does for me or the few that have borrowed it from me in my guild till it is part of the updater. Does it have to be my changes, not at all. Was simply offering a helping hand.

As for adding anything, I only added the the check box. As for any other changes I only modified 10 spots where it references how the storylines screen was drawn and basically shorted the box enough to allow the checkbox to display properly and not overlap the story list. The changes there were changing reference locations and were originally 320, 398 and 320, 380 and changed them to 320, 364.

Again, it works for me so I am happy with it till the official patch version is in place.

I leave it now to the powers that be to decide if it can be added or not. Here is how it looks for me at this time. I am using full profitUI with current files from the updater and the only exception is the modified journal code where I made the modifications to show the check box for "Hide Completed Storylines".

[Papabard]

I'm not the powers that be but maybe TalTal can add it to the updater but still think simply adding it as a downloadable attachment is good as some may not want the checkbox. After all the storyline is from my understanding simply to follow the reason behind the quest. I hardly even look at that page myself.

Nice job though because until today I didn't even know it was missing a checkbox.

The one I edited from the updater I simply added a single line of code for the checkbox. I think you might of cleaned up the display with the addition of the background around the checkbox.

Didn't mean to sound like it wasn't a good addition like I said just think 1 person should continue to maintain the project and simply make suggestions to that person so we don't end up with a broken ui or a community project where everyone is making changes.

[gm9]

Originally Posted by Papabard

Didn't mean to sound like it wasn't a good addition like I said just think 1 person should continue to maintain the project and simply make suggestions to that person so we don't end up with a broken ui or a community project where everyone is making changes.

Well, it's for Silat to decide how he likes to run it (if he still is running it actually) but if I could choose between a suggestion and a working piece of code that I only needed to approve I know what I would prefer if I was him.

Of course there is always personal style, e.g. when I would be doing the window I'd cringe at all the wasted space and move the checkbox into one of the already unused areas. Also who moved my top tab buttons in front of the frame, that looks ugly?! Haha, don't mind me, good job guys.

Also Papabard reminds me of Spiricore who had started to bring some order into the various user contributions that started appearing on the forums after Profit left and before I took over. In other words you must have someone in the lead but he does not necessarily have to provide the code, and I see you slipping into that role, hehe.

Alright, enough of my rambling, keep on doing whatever you were doing.

[Zlar]

Originally Posted by Papabard

Didn't mean to sound like it wasn't a good addition like

Did not take it in that way either and know you are taking a "protector" type role over it.......and someone should .

I am an avoid Quester closing in on 5,000 completed so I look at all ways to find out what quest may have been missing. The Storylines tab helps with that. I know, I did not really consider that as well till I forced myself to spend time on it to understand it. Basically it shows all the storylines in game to date and all related quested to the storyline. With this, you can see what quest you still have left to do. You may not even know you were missing a quest.

For example, after I added the checkbox and hid the completed ones I saw that I had one for Butcherblock. I thought how strange was that as I had done all the BB quest. Turns out that a new one was added near the lFay camp where they also added a road to SF. There was one quest there I missed. If not for the storylines tab I am sure I would have continued to miss it.

Originally Posted by Papabard

I think 1 person should continue to maintain the project and simply make suggestions to that person so we don't end up with a broken ui or a community project where everyone is making changes.

I also agree, but at the same time did not know who that was, the process to make a request, if the request would be considered or even how long it would take to add if considered.

I would like to know if it does get added to the updater's as I do not want to keep separate code either

[Papabard]

Both versions of these files do the same thing. 1 is a direct addition of a single line of code adding the check box. As to why they differ is beyond me but here is my code for you to compare Zlar just so you can see what I have been talking about. Maybe its the way I have my WinMerge setup it could be whitepace etc that puts huge chunks into yours

[Zlar]

Originally Posted by Papabard

Both versions of these files do the same thing. 1 is a direct addition of a single line of code adding the check box. As to why they differ is beyond me but here is my code for you to compare Zlar just so you can see what I have been talking about. Maybe its the way I have my WinMerge setup it could be whitepace etc that puts huge chunks into yours

Thanks for posting your code. I took a look at it, not using XML compare tools but in EQ itself so I put your file in my profitUI directory to see what it looked like and the image is below. It is the same thing I saw on my initial efforts, before I post any of the code. While simply adding the checkbox line does the job, it did not address the need for redoing the page for space management. That is where I did the 10 (approx) changes to graphic location references, to make it so the checkbox did not overlap the listing.

I am guessing that your code looks OK for you when used in game?

[Zlar]

OK, wanted to post an additional item I am seeing between your version and mine, other than the spacing issue for the checkbox. When looking back over the image I just posted with your XML code and of mine I did notice something I did not really see before. The tabs at the top or in a different location for mine than yours. So, to see who's was off, I re-downloaded from the updater to see what it looks like. And the tabs look like yours. So somewhere one of the areas where I changed a location reference I may have changed one that was not needed. That would possible explain why the are in a different place for me.

Did not hurt anything, and does not explain why you are seeing "chunks of missing data" as I took nothing out no did I do any form of formating the XML.

I still may tinker with my changes to find out which of the 10 changes I made moved the tabs to a new row. Interesting, as that was not the intent.

[Papabard]

well see thats what I didn't know. Now I can look closer at the code and learn a bit.

[gm9]

Originally Posted by Zlar

So somewhere one of the areas where I changed a location reference I may have changed one that was not needed. That would possible explain why the are in a different place for me.

The only likely explanation is actually that you based your window off the default UI's version. The tabs on top thing is a ProfitUI particularity I did to save space (although the tabs are supposed to be behind the frame), other windows like market window or browser have that, too. You could do the same thing on the bottom btw.

[Zlar]

OK, I have taken a look even deeper and believe I have it fixed , adding in the checkbox again and leaving the tabs where they are and shortening the storyline listbox so that it makes room for the checkbox. Take a look and see how that looks for you as well.