 |

06-16-2009, 12:06 AM
|
 |
A Griffon
|
|
Join Date: Nov 2004
Server: Guk
Posts: 536
|
|
New Version 0.5.1
New Version Below . . .
Fixes
I think I've got fixes for most of the bugs listed above. - Zoom now has an upper limit of 1000% and a lower limit of 50%. There shouldn't be any way to get around this.
- Zoom with no map loaded will no longer cause a crash.
- Loading a language with no map loaded should no longer cause a crash.
- Auto-Loading the SVG file is now an option and the code checks if there is a file association for SVG prior to launching.
- Disabled the ability to edit the zoom drop-down
- Disabled the ability to edit the language select drop-down
Features- I've added a "Clear" button which clears the current map and the logfile listed.
- SVG auto-load is now optional and off by default (Setting Menu).
- Map Style Name is now user editable. Detecting it in the log file will overwrite anything that was typed.
Unable to Reproduce- Auto-Parse not working (see prior message)
- SVG min/max numbers orders of magnitude too big.
This may be related to some culture setting, but I double checked my code and it should force the output to US culture settings for the SVG output. I ran the sample french input file you provided. I'd like to see the actual .svg output, as it may have some clues for me.
__________________
Last edited by SaintPeter : 06-16-2009 at 10:25 AM.
|

06-16-2009, 03:53 AM
|
|
gm10-1
|
|
Join Date: Feb 2006
Posts: 6,479
|
|
- Your code needs to check .svg association before trying to launch the file, it's throwing an error if it was configured to autolaunch and the association is then removed
- You cannot turn off autolaunch of .svg if there is no association
- still can't select English language, so after loading a French log I can't load English logs anymore. Just autodetect the language already anyway man, just put all the language strings into an array and use whichever matches first, or merge them into a single regex, there's so few strings that performance impact will be minimal. And you coud even read mixed-language logs like that.

- mapstyle name is not saved when autoloading the log upon relaunch of the app
- seems like it's trying to autodetect the EQ2 folder for logs (there's a setting in the .config) but it fails at that and instead opens the "my documents" folder. On my system instead of E:\Everyquest II\logs it wrote E:\\logs to the .config.
- Dragging and dropping a log file should make it default to the folder of that log file IMO
- The decimal comma is definitely being ignored, .svg of the log I sent you attached.
- Switching just the decimal setting to a dot instead of a comma does not fix it.
- Changing the log file from using a comma to a dot (and adapting your regex to deal with it) does not fix it.
- However, switching my system to US English regional options fixes it.
So your code is messing up there. It should detect whatever is in the file, not what regional setting the system has selected (or if it does, it should at least correctly detect the decimal separator setting, not the overall profile name).
Last edited by gm9 : 06-16-2009 at 04:00 AM.
Reason: formatting
|

06-16-2009, 10:22 AM
|
 |
EQ2MAP Developer
|
|
Join Date: Jan 2006
Server: Splitpaw
Posts: 1,705
|
|
The UL and LR vaules is missing the comma and i think UL Y is the same as LR Y or the otherway around :P
There is no limit to how much text you can enter in Style Name, you can fill it with hundreds of chars.
There version string is wrong again , you should consider using a constant :P
__________________
Pimigo / Splitpaw
|

06-16-2009, 10:28 AM
|
 |
A Griffon
|
|
Join Date: Nov 2004
Server: Guk
Posts: 536
|
|
Quote:
Originally Posted by jnils
The UL and LR vaules is missing the comma and i think UL Y is the same as LR Y or the otherway around :P
There version string is wrong again , you should consider using a constant :P
|
Haha! I have already fixed both of these issues (I think). See version 0.5.2. I was actually using the code from the EQ2MAP updater, but what I didn't realize is that it uses the first, second and FOURTH numbers in the revision field, not the first second and third.
Quote:
Originally Posted by jnils
There is no limit to how much text you can enter in Style Name, you can fill it with hundreds of chars.
|
Well, as long as it doesn't cause a crash . . . :P
I'll see about adding some limits there in the next version.
__________________
|

06-16-2009, 10:24 AM
|
 |
A Griffon
|
|
Join Date: Nov 2004
Server: Guk
Posts: 536
|
|
New Version 0.5.2
http://www.bellumaeternus.com/mapper...Live_0.5.2.zip
Quote:
Originally Posted by gm9
- Your code needs to check .svg association before trying to launch the file, it's throwing an error if it was configured to autolaunch and the association is then removed
- You cannot turn off autolaunch of .svg if there is no association
|
Ok, I had the association check backwards (d'oh), and I didn't check it prior to actual launch. I now do, and I've wrapped a Try block around the launch code, just in case.
Quote:
Originally Posted by gm9
- still can't select English language, so after loading a French log I can't load English logs anymore. Just autodetect the language already anyway man, just put all the language strings into an array and use whichever matches first, or merge them into a single regex, there's so few strings that performance impact will be minimal. And you coud even read mixed-language logs like that.

|
I'll take it under consideration.
Quote:
Originally Posted by gm9
- mapstyle name is not saved when autoloading the log upon relaunch of the app
|
I'm not sure that I want to. I suppose it's easy enough to do, I just have to save it when I close, but I need to make sure to only reload it if it's the same file. I'll see what I can do.
Quote:
Originally Posted by gm9
- seems like it's trying to autodetect the EQ2 folder for logs (there's a setting in the .config) but it fails at that and instead opens the "my documents" folder. On my system instead of E:\Everyquest II\logs it wrote E:\\logs to the .config.
- Dragging and dropping a log file should make it default to the folder of that log file IMO
|
Yeah, I figured out what I was doing wrong with the auto-detect. That should be fixed now. I also added the capability to remember the last used logfile directory, which I also added to the drag and drop.
Quote:
Originally Posted by gm9
- The decimal comma is definitely being ignored, .svg of the log I sent you attached.
- Switching just the decimal setting to a dot instead of a comma does not fix it.
- Changing the log file from using a comma to a dot (and adapting your regex to deal with it) does not fix it.
- However, switching my system to US English regional options fixes it.
|
Ok, I think I finally have this one licked. I can't auto-detect the setting of the file because it may have mixed languages. What I am doing, now, is to force the program to use US settings and I do a search and replace on the comma, replacing it with a period. When I had changed my system settings to fr-FR, I actually got an exception, so I'm not sure how it even worked on your system at all.
What I want to occur is that the files will always be handled identically, regardless of the country they are in. That way I can write my code uniformly and just move everything to a single standard.
Anyway, check out the fixes.
Thank you for continuing to hit this with a hammer. I'm getting better code because of it.
__________________
|

06-16-2009, 11:05 AM
|
|
gm10-1
|
|
Join Date: Feb 2006
Posts: 6,479
|
|
Quote:
Originally Posted by SaintPeter
When I had changed my system settings to fr-FR, I actually got an exception, so I'm not sure how it even worked on your system at all.
|
Likely explanation is that I'm not French and that I never tried with that setting.
Quote:
Originally Posted by SaintPeter
What I want to occur is that the files will always be handled identically, regardless of the country they are in. That way I can write my code uniformly and just move everything to a single standard.
|
One way to deal with it would be to split it up while regex parsing, i.e. search for something like (-?\d+)[,.](\d{2} to pull both parts of the decimal in separately regardless of the actual separator used.
Quote:
Originally Posted by SaintPeter
Anyway, check out the fixes.
|
Will do. 
EDIT: Seems to work now. Good job.
Quote:
Originally Posted by SaintPeter
Thank you for continuing to hit this with a hammer.
|
It's what I do best. 
Last edited by gm9 : 06-16-2009 at 11:07 AM.
|

06-16-2009, 10:57 AM
|
 |
EQ2MAP Developer
|
|
Join Date: Jan 2006
Server: Splitpaw
Posts: 1,705
|
|
Nice fixes, found ony 2 things.
- If you move a map to the edge of the screen and reload a new log, it don't re-center.
- The zoom vaule don't change the first click you zoom out even if the picture gets smaler.
__________________
Pimigo / Splitpaw
|

06-16-2009, 11:37 AM
|
 |
A Griffon
|
|
Join Date: Nov 2004
Server: Guk
Posts: 536
|
|
Great feedback guys, I really appreciate it. I think that the code is stable enough right now that I'll work on the next major revision. My focus for the next release will be additional information provided to the user about what the program is doing. I'll be adding status bars updates, etc. I'm also going to focus on getting the layers interface to work better, display more information, and have a cleaner look and feel.
The 0.5.0 release showed me that I probably need to do some code reorginization. I need to better encapsulate my parser and mapdata classes so they can't GET into bad states like they were. I ended up putting a lot of band aids on them which really need to be turned into changes to the class structure.
__________________
|

06-16-2009, 11:45 AM
|
|
gm10-1
|
|
Join Date: Feb 2006
Posts: 6,479
|
|
Quote:
Originally Posted by SaintPeter
The 0.5.0 release showed me that I probably need to do some code reorginization.
|
Looking forward to hammer the bugs you'll put in doing that.  j/k
|

06-23-2009, 11:53 PM
|
 |
A Griffon
|
|
Join Date: Nov 2004
Server: Guk
Posts: 536
|
|
New Version 0.6.0
http://www.bellumaeternus.com/mapper...Live_0.6.0.zip
New Features
- New Layers Interface - Pretty Drop Down box
- New "Extents" info display - also a pretty drop down box
- New Command: /em groupname <My Name Here>
Allows you to set the name of the first layer. Has not been translated to other languages
- Status Bar now shows last command and other statuses
- Status Bar now has Line and Point Counts, Current Color, and Current Line Weight
- You can't see it, but the underlying structure has been largely rewritten to make it a bit cleaner. This is mostly to make the code a bit more presentable and makes me feel better. It may have also reduced the number of stupid bugs.
Bug Fixes- Fixed parse error when numbers exceeded 1000 in english and other languages.
- Fixed the scaling of the Extents lines so they are no longer unreasonably big in the SVG output.
- re-added the min/max z values in the SVG output.
Random Thoughts
I'm pretty comfortable with the current feature set. I have a couple other ideas up my sleeve, but I don't know how useful they'd be in the long run. This basically covers the feature set of the old Mapper2, plus a couple of bells and whistles. It should be easier to use and work with Unicode and other languages and stuff.
I'm away next week, so it'll probably be a bit before I put out another version, except for any immediate bug fixes needed for this one.
Possible Features
Shout if anything here catches your fancy. - SVG Output Options
Maybe add the ability to output each layer as a seperate file. The data structures exist to enable this, just have to write the code.
- Image output options
IE: Background color, Transparent, Size options, draw extents, etc.
- Display Features
- Highlight last point
- Highlight current line
- New Input Command: Circle from 3 Points
- It's possible to determine the center and radius of a circle that passes through 3 points. I am thinking about adding vector circle support. You would just say "/em start a circle" followed by 3 points representing the edges of the circle.
- Your Feature Here
If it's interesting enough, and doable, I'll consider it.
__________________
|
Posting Rules
|
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
|
|
|
All times are GMT -5. The time now is 09:48 PM.
|
 |