Storyline Tab in the Journal.

[gjsi]

Not sure if the default UI has it, but told there was a checkbox on the storyline tab to hide completed storylines, I don't see this on the Profit Storyline tab, is this going to be added, or did I miss an update somewhere?

[Zlar]

Originally Posted by gjsi

Not sure if the default UI has it, but told there was a checkbox on the storyline tab to hide completed storylines, I don't see this on the Profit Storyline tab, is this going to be added, or did I miss an update somewhere?

It is not added yet. However I did manually modify my ProfitUI code to allow for it and have posted a link to it here. I hope that the powers that be will take the code and add it to their updater.

But for now if you wish to manually modify your file take this code and copy it over your existing code for "eq2ui_journals_quest.xml" located inside your ProfitUI folder.

http://mysite.verizon.net/res12s1kz/...nals_quest.xml

[Papabard]

Good file. However doing a compare its missing a lot of code compared to the one currently on the updater. Looks to be missing the search buttons area complete block and another large chunk around the top of the file. Was this a moddied profit file from recent updates or the default with stuff added in?

[Zlar]

Originally Posted by Papabard

Good file. However doing a compare its missing a lot of code compared to the one currently on the updater. Looks to be missing the search buttons area complete block and another large chunk around the top of the file. Was this a moddied profit file from recent updates or the default with stuff added in?

It is possible that it needs to be cleaned up some. What I did was take the most recent file from the updater, remove the storyline block from the xml file and replace it with the storyline block from the default ui. No other changes were made. I just did a reload of the one from the updater and do not see any features such as a search buttons on the storylines area currently. From all I can tell the changes I am using only modified the storylines so that the display box on the left was a bit shorter to allow for the checkbox to be displayed below it, like in the default ui.

[Zlar]

OK, my initial change was more a "brute force" change and did not take into consideration other areas that may have been impacted. I went into the code a little cleaner this time around and mode on the changes that were needed. You should not see at least 1 addition (might show as 1 deletion, depending on how you compare). This was the addition of the Checkbox tag for "Hide Completed Storylines". There should also be approx 10 changes. This was to address the changes in real estate to allow for the checkbox to appear at the bottom and taking away some of the space used for the listbox of storylines. I have updated the code on my web location for review. Hopefully these changes will be what it takes to get added to the updater.

[Papabard]

Just my opinion here but I much rather have a single person updating this UI at the moment that is TalTal and what I have done in the past was suggest to him changes. If the window is missing a checkbox I would ask that he put that in.

I did another compare and it seems instead of just adding the check box you're moving code way down and this is giving me a display of large blocks of text missing from the file you have and the file on the updater. The line numbers are way off so the compare displays to me as being very heavyly modified file compared to what is on the updater.

I am sure TalTal can add that check box in. If its not on the updater one can always add it as a modified version for users to choose to use over what is. This is what I did with the Persona window where I modified just the inclusion of the Spell only reuse.

[Papabard]

Both versions of these files do the same thing. 1 is a direct addition of a single line of code adding the check box. As to why they differ is beyond me but here is my code for you to compare Zlar just so you can see what I have been talking about. Maybe its the way I have my WinMerge setup it could be whitepace etc that puts huge chunks into yours

[Zlar]

Originally Posted by Papabard

Both versions of these files do the same thing. 1 is a direct addition of a single line of code adding the check box. As to why they differ is beyond me but here is my code for you to compare Zlar just so you can see what I have been talking about. Maybe its the way I have my WinMerge setup it could be whitepace etc that puts huge chunks into yours

Thanks for posting your code. I took a look at it, not using XML compare tools but in EQ itself so I put your file in my profitUI directory to see what it looked like and the image is below. It is the same thing I saw on my initial efforts, before I post any of the code. While simply adding the checkbox line does the job, it did not address the need for redoing the page for space management. That is where I did the 10 (approx) changes to graphic location references, to make it so the checkbox did not overlap the listing.

I am guessing that your code looks OK for you when used in game?

[Zlar]

OK, wanted to post an additional item I am seeing between your version and mine, other than the spacing issue for the checkbox. When looking back over the image I just posted with your XML code and of mine I did notice something I did not really see before. The tabs at the top or in a different location for mine than yours. So, to see who's was off, I re-downloaded from the updater to see what it looks like. And the tabs look like yours. So somewhere one of the areas where I changed a location reference I may have changed one that was not needed. That would possible explain why the are in a different place for me.

Did not hurt anything, and does not explain why you are seeing "chunks of missing data" as I took nothing out no did I do any form of formating the XML.

I still may tinker with my changes to find out which of the 10 changes I made moved the tabs to a new row. Interesting, as that was not the intent.

[gm9]

Originally Posted by Zlar

So somewhere one of the areas where I changed a location reference I may have changed one that was not needed. That would possible explain why the are in a different place for me.

The only likely explanation is actually that you based your window off the default UI's version. The tabs on top thing is a ProfitUI particularity I did to save space (although the tabs are supposed to be behind the frame), other windows like market window or browser have that, too. You could do the same thing on the bottom btw.

[Zlar]

OK, I have taken a look even deeper and believe I have it fixed , adding in the checkbox again and leaving the tabs where they are and shortening the storyline listbox so that it makes room for the checkbox. Take a look and see how that looks for you as well.

[Papabard]

well see thats what I didn't know. Now I can look closer at the code and learn a bit.