Quote:
Originally Posted by Papabard
Just my opinion here but I much rather have a single person updating this UI at the moment that is TalTal and what I have done in the past was suggest to him changes. If the window is missing a checkbox I would ask that he put that in.
I did another compare and it seems instead of just adding the check box you're moving code way down and this is giving me a display of large blocks of text missing from the file you have and the file on the updater. The line numbers are way off so the compare displays to me as being very heavily modified file compared to what is on the updater.
I am sure TalTal can add that check box in. If its not on the updater one can always add it as a modified version for users to choose to use over what is. This is what I did with the Persona window where I modified just the inclusion of the Spell only reuse.
|
Hmm....not sure why it looks different for you than it does for me or the few that have borrowed it from me in my guild till it is part of the updater. Does it have to be my changes, not at all. Was simply offering a helping hand.
As for adding anything, I only added the the check box. As for any other changes I only modified 10 spots where it references how the storylines screen was drawn and basically shorted the box enough to allow the checkbox to display properly and not overlap the story list. The changes there were changing reference locations and were originally 320, 398 and 320, 380 and changed them to 320, 364.
Again, it works for me so I am happy with it till the official patch version is in place.
I leave it now to the powers that be to decide if it can be added or not. Here is how it looks for me at this time. I am using full profitUI with current files from the updater and the only exception is the modified journal code where I made the modifications to show the check box for "Hide Completed Storylines".
