Request for changes to eq2map
 

Hey guys what up.. I have some ideas for you to chew on.. (Attached)

I have found, what I think is, a better way to plugin options into the EQ2Map project.. I have modded it so that you can have 4 "plugins" installed at one time.. Changes in EQ2UI_Mainhud_Map.xml are minimal for this.. 4 includes and 4 lines of script

I have also made some examples (Edit: not 100% done with any, but they all work well enough to install and check out)
There's 6 or 7 examples but they are not polished just wanted to get them in there to show some examples on using them and to test it..

I also implemented a minimap feature.. Changes for this are many.
Edit: I'm not 100% done with everything yet.. Still needs polish.. But it's in a good enough shape to be shown..

off hand I remember:

I had to move the Icons out of QM_Overlay into the MapPage and renamed it QM_Icons(So they could be dragged with it)
Had to change a lot of scripts in quite a few files for this.. (Under_ files)

I added two buttons to the titlebar for minimap feature.. Also had to add two windows to make a different style window when in mini-mode.. (Window frame and title bar needs to be on way top)

I changed the way the MapBorder works.. (Seperated into 2 windows(files) MapOverlay and MapUnderlay)

I changed the way QM_MinimizeButton and QM_RestoreButton worked so I could "press" them through my scripts..

I also added a MapImageOverlay.. I use this in one of the options to make the maps a little darker.. I don't like them so bright..

I'm sure you will rip it apart if you like it :p If you have any questions let me know..

Here's a jpg of the Minimap: http://www.eq2interface.com/forums/a...tid=1652&stc=1

Edit: I don't know if this works with autoupdater at all.. I used latest download available when making it.. Should be installed over that..

I will polish it all up if you guys like it..

Ok, here's the deal: I'll look over your code and give it a fair analysis, but keep in mind that the structure was decided upon during about a month of testing and brainstorming. There's already a couple things that I can comment on before even reviewing the code.

The minimap feature by default is a no. It's far above and beyond the default map window functionality. To have it as an optional mod is good though as long as it can be worked into a decent plug-in form.

Moving the overlay to within MapPage completely destroys the idea behind the overlays. Rather than those POIs being hidden by the fog, you can see them upon zoning in (into a new zone where none of the fog has been uncovered) because they are a layer above the fog (and unfortunately the location arrow).

The changes to mapborder, minimize button, added optional plug-ins and the darkening overlay (for people who have their brightness turned up too high perhaps?) I will go over with a fine-tooth comb (well, I will really go over it all very carefully). So I'll let ya know what's up later.

Quib

Ahh I see, I didn't think any think was set in stone yet.. I tried not to hack it up too bad.. Just what was absolutely needed for the minimap.. But thanks for looking :)

I didn't mean for it to be a standard feature.. Could make a plugin that makes the buttons visible.. I tried to implement it in a way that it would work with any skin, as long as they re-skinned the two dockwindow pieces.. Also, I didn't think you were trying to keep it "simple" or mimic the default so closely..
I just can't stand that huge map window (It should be resizable and have scrollbars)

Unfortunately, unless you move those icon's, I can't really see a way of making a minimap feature.. Unless you figure out how to move the map and overlay with buttons which could work.. I set it up so you grab the MapPage to move it.. If the icons are seperate they won't move with the map.. Too bad there's no OnMoved event :p

I'm pretty sure the location arrow part can be fixed.. As for the POI's being under the fog that's closer to the default map window functionality :p J/K

Is there a way to remove the fog all togethether? It would make the all the maps work the same (no fog, like all added maps?)

The mapborder changes were needed to make the minimap. No other reason.

I can tell you it's not my brightness.. Most people tell me my settings are too dark.. I just think the map parchment paper is blaringly bright.. The only way to darken it is to darken the whole images :(

The plugin system is basically the same as before except it uses 4 windows as pluging slots..

Again thanks for atleast looking at it..

Ok, your minimap is impressive, I'm still sorting through everything it needs to be functional.

The fog issue has come up a few times, the "best" way to remove the fog results in the users location arrow not showing up until they've zoned once (or changed halves of the map in two+ map zones). This is an unacceptable kludge; the other problem is very specific conditions have to be met for it to work at all: the map window must be closed when camping, and opened once before the first zoning. Also, I'm not sure SOE really approves of us defeating the fog layer, it's actual pretty hard to get around.

Here're the three basic goals goals I have in mind when working on the format of the map window:
1) Same size as default (this one seems to bother mod authors the most; the style sets allow this to be modified, but by default the map window should LOOK just like the default map window. We're adding maps not trying to dictate the users UI style).
2) Pack it full of information that isn't in the default UI elsewhere, but don't repeat data (this is why, by default, the map window doesn't have a label for your current loc, though I must say, your when-mouse-isn't-over path finder thing was really clever).
3) Avoid changing default functionality of the map window beyond a certain point (which is arbitrary, this is the most wishy-washy of my rules).

The minimap conflicts with goal 1; a second window increases the screen real-estate of the map window, even if it can be hidden. The quests window is an example of a feature that will increase the map window size, but will be an optional download. The minimize button conflicts with goal 1 but is being left in due to a grandfather clause; it's been there since really early on. I should probably make it a plug-in, but it's not high on my priority list.

Goal 2 actually also conflicts with the minimap; it's repeating data already visible in the map window. Keep in mind I love the idea of a minimap and will be using one myself (I've played with Zonx's minimap in various forms quite a bit). So my arguments against one aren't due to a personal aversion to a minimap in particular.

The minimap really doesn't conflict functionality-wise I guess, it's just another map. The no-closing-on-escape violates this goal, but, like the minimize button, it's been there since early on. I'm leaving this one in and just relying on an optional download to restore closing-on-escape. The pathfinder doesn't conflict with this because it's simply another POI; the user can just plug in the loc data manually.

Anyway, I'm not dismissing your work or anything, I'd like to implement all of it in some form or another most likely, it'll just be a bit; we're 99% done with the full auto-updating system and so am tied up with bug shooting that right now.

Quib

Just remember it's just a preview.. I uploaded it to see if it's worth the effort for me to pursue..

I tried getting it not to display (when I was working on the map in my UI) but had no luck.. I will have to check out your method..

Personally I think the only thing the fog is good for is showing where you explored and where you didn't.. Anyone who has brains enough to download your mod has brains enough to check out the maps on maps.eqInterface.com before actually exploring there. Makes the fog kind of annoying when you know what the map already looks like.. I know many people that would agree with me.. I don't see why sony would get upset if it was removed :D However the problem you described gets in the way..

It actually looks like there are 2 fog layers in the game.. If you look at the black fog you can see like a drop shadow underneath it.. That dropshadow, I believe, is the fog they use in citys.. Wish we could get rid of the black but keep the semi-transparent..

Wish we could find the name and location of the fog elements so we could manipulate them in scripts..

I can probably set it up without moving the QM_Overlay but it would require 9 pages of 8 buttons on each page.. Thats 72 buttons to code and it makes it less functional IMO.. Or 9 pages and 8 buttons with a ton of scripting.. But I'm taking a break from modding today!

Never sacrifice features for looks!! Sony released a 1/2 finished UI system.. 100% evident in the map window and the chat system.. Features like minimize and restore(Like eq1 had but better).. and a resizable map window(EQ1 didnt have but it should!) should have been in the game since release.. Along with all the maps you guys are adding.. Adding buttons doesn't change the "look" of the window just adds some function..

Minimap doesn't add a window per say.. It makes the map smaller when you press a button.. Takes up less real estate.. It doesn't actually open another window.. When the button isn't pressed it looks just like the default with an extra button.. :p


Actually it's not repeating anything.. It changes the layout of the window.. It's the same window there for no way it could repeat information..

Again it doesn't add anything it changes the layout of the window.. It doesn't change any funtionality it just adds some! And I was working on making it an optional download from the start.. The default download would have 2 "blank" windows in it for minimap to plugin to..

I don't see you as dismissive.. If you were you wouldn't have even looked at it or replied.. And, we wouldn't be discussing it at all :)

I'm picking this apart myself too. If we're lucky we can find a way to make it so that this can be a plug-in for the map without altering the existing functionality (and thus not have Quib be bugged by it. :p)

In the meantime, we should be able to get the overlay to recenter with OnHoverIn and OnHoverOut, it just won't move directly with the MapPage. (Or would it be vice versa?)

I've been wondering about these since I saw people adding them to various mods.. What do people use minimize for? I mean, everything is tied to a toggleable hotkey anyway, so why add a repetitive feature?

Totally misunderstood the code I was looking at with your minimap Talyns. I thought it was doing another window Zonx minimap style. I actually haven't been able to load it in-game because there's been a couple big changes getting ready for fully auto-updating and didn't have a copy of the last release handy. Guess I'll go download what I uploaded. =D

Hehe, I believe form is as important as function, so we've got some ideological differences here. Other than a 1 pixel gap between the default map window's titlebar and the rest of the window, I didn't see anything half-finished about it. I agree that buttons don't hurt a window, I just feel keeping proportions the same is important. When I load a non-default UI, I don't want to HAVE to move a single window; keeping the map window its original size means it's exactly where the user expects it to be.

Killarny, the main reason I originally tacked a minimize button on the map window was because of the pathfinder; you can use the map window solely for getting paths to locations without having the whole map block your view. Also remember that was months ago, and stuff like minimize buttons were fresh off the drawing board as OnEvent capabilities were first being realized.

Quib

I wasn't criticising, just asking about something that's made me wonder for a while :)

Breaks over, here's a version where I didn't mess with QM_Overlay

Only changes to eq2ui_mainhud_map are some includes and 4 lines of code for the plugins.. Map now moves in minimapmode with 5 buttons that are part of the Minimap Window..

Check it out :)

Note: You should NOT install this over my previous proposal.. It will not work correcty..

Edit: Just wanted to add: I don't know what I was thinking of with the 9 pages and 8 buttons on each page.. Thank god it only took 5 buttons!

The whole map system (And UI for that matter)is half implemented.. The fog and encrtypting of maps is a good Idea (If you're gonna do maps for every zone in the game).. The fog is good because it covers their icons.. They could have had very detailed maps with icons to everything (because you can't see them till you find them), and eliminated the need for mapsites.. The map window that ships with the game could have been left out completely and I wouldn't of missed it.. The way it is now (without eqmap) I have to switch in and out of game and look at the various map sites to find what I'm looking for.. Even for zones where maps exist in game..

That's what I meant by the 1/2 finished comment..

I use them in my chat window, because there is no hotkey..
Also some people don't use the keyboard for anything but chatting..

I missed this before sorry..

I'm trying to make it a plug in.. It's a work in progress..

In fact, in the version I just uploaded, to rip it out you would just include 2 "blank" includes for the minimap.. I still have to set it up that the dock and undock button are hidden unless the option is installed but I consider that the polish work.

I don't want to do any polish work on something that isn't going to get used :D

Actually, it looks like we don't need the script changes either. Basically we just need two <include>s placed BEFORE QM_Overlay in the main file. Just have the ones that come with the main download just be blank or zero-size absorbsinput=false pages, and we're good. Name them window_overlay1.xml and window_overlay2.xml or something. :p (We might actually only need 1 for this, but two would be nice in case something else comes up. Why not make it 3?)

That work, Quib? :)

I know we don't need the script changes for the minimap, those are for the plugin system I made :)

I tried getting it working with only one overlay but couldn't get it to move all the time.. The second one is the titlebar and lets you move the window when in mini map mode..

I'm working on seperating it completely from eq2map right now.. The only thing that will be left is 2 "empty" buttons it the titlebar xml.. The mini map will be self contained in three files!

Ok I'm done seperating it.. Check out how it could work..

Note: I added another plugin slot called TM_PluginMinimap.. This is what sets the dock and undock button when its installed..

So the only changes to eq2ui_mainhud_map.xml are a bunch of include changes and 5 lines of script in onshow2..

Edit:
The script additions are:
TM_PluginMinimap.Visible=true
TM_Plugin1.Visible=true
TM_Plugin2.Visible=true
TM_Plugin3.Visible=true
TM_Plugin4.Visible=true

All of the added includes are blank.. With exception to the mapunderlay and overlay.. They make up the map frame and tan background that was in window_mapborder.xml

Gah you did a lot while I was busy this evening. So here's the deal: we DEFINATELY will get this worked in. Default will be empty files (like Eloa's eventual quest plug-in). Like Eloa's quest plug-in, I want the "slot" for the minimap to be able to be used for other functions should the end user see fit (well and some modder to come up with something). Give me a little time to look over the new stuff and see how it works. So that I'm not going in blind, can you explain (again, sorry) why the split in mapborder.xml?

Killarny, no worries, was just giving you a fair response to your question about the minimize button; I only saw you as asking a question, not criticizing or anything.

Quib

The reason for splitting it is so the frame is on top of the map at all times because the map moves around the window.. I don't use the mapoverlay in the proposal version when in minimode but some modder might use it for something..

The underlay stays under the map.. Its basically the tan color..
I use the under lay to hide the tabpane when in minimode..

That change isn't 100% needed.. But it makes things so much easier.. Also, it's something skinners can use when modding..

Edit: Also I would add one extra Window_Overlay thats on top of everything.. Just incase a modder finds some use for it..

Edit2: I would suggest removing the QM_Loc window from titlebar to it's own window and put it on top of the minimap so I can make it visible in docked mode!! Maybe include the include statement in the window_overlay from the above edit!!

I want to add something else to the above message.. I also edited the above message twice so please read edits..

I actually did a lot more work last night! Making the changes I did tonight were minimal compared to that.. I tried to make it as modular as eq2map itself from the start :)

Version 3 is set up like what I thought you would have in mind for eloa plugin.. It just takes 2 windows and a plugin to accomplish it :)
The "plugin" "slot" (LOL) shouldn't be hard coded in anyway..

I will polish up(graphically and functionality) the Minimap plugin when/if you give me the go ahead and I get a new eq2_mainhud_map.xml from you with support for it..

Quick reply before I get to bed. It used to be this way (long before EQ2MAP was modular) but then it didn't receive the "Frame and Title" opacity settings (which it's a part of). I recall they added some sort of transparency matching properties for the chat window and the tab bar, but changing the structure here would involve a LOT of changes. Every single POI icon would need its OnHoverIn changed.

My afternoon tomorrow is free. I'll sleep on this all and see what needs to be done to make this work. There aren't really "if"s here; I'm gonna find a way to work in support for both your and Zonx's minimap styles; it'll take compromises on both our parts I'm sure (well, as far as one UI window is concerned =P), but support from and for the EQ2UI community is important for this project.

Quib

FrameControl and BackdropControl

That's no big deal No need for it really when in minimode I guess.. You can still click the POI's

Cool.. That's what I like to hear!!

I'm attaching updated plugins.. All working as intended I believe..

I was thinking maybe put all the plugin includes in it's own page
Then only include that page in EQ2UI_mainhud_map.xml..

The OnShow of that page should show all the sub-pages (plugins) to initialize them..

Then it's only one line in the onhide2 script
And one include for the plugin system..

Go get some sleep :p

I'm working on the plugin system and have made it so simple and useful imo..

The minimap will be a plugin and work like all the rest of the plugins..
The way the map moves with the buttons now it only needs one page.. Come to think of it I could have probably got away with one page from the beginning like deathbane said..

The only impact on any of your files will be one include and one line of script in the mainhud_map file..

I'll have a proof of concept up to look at in a bit..



Edit: oops and a couple minor script changes the qm_buttons and wc_close buttons in the WindowTitlebar so I can press them through script.. But I don't need to add any buttons there now :)

Ok here it is..
I lied there were 3 changes to the EQ2UI_Mainhud_map.xml..

1. Added TM_Plugins.Visible=true to the onhide2 in the map page..
2. Added an include for plugins.xml above the QM_Overlay Page
3. Broke apart the map border..

If you look at the included fuile (plugins.xml) you'll notices that it has 5 includes there.. They are not located in a page.. And a page (MainHUD.Map.TM_Plugins) This page initializes the other pages..

The 5 includes make 5 pages in MainHUD.Map not MainHUD.Map.TM_Plugins..

All the plugins are blank right now.. I only did one and that's the Minimap..

If you look at the minimap you'll notice that it use Plugin_1.xml instead of a unique one..
If you look at it you'll notice it's a page and 2 includes outside of the page.. The 2 includes outside of the page adds 2 pages I need right to MainHUD.Map..


In other words the every page I add is a child of Root.MainHUD.Map.. The xml tree looks like this without my modifications:

-Map
--QM_Overlay
---Icons

When I add the plugins file to it the tree would look like this

-Map
--TM_Plugins
--TM_Plugin1
--TM_Plugin2
--TM_Plugin3
--TM_Plugin4
--TM_Plugin5
--QM_Overlay
---Icons

When I add my minimap:
-Map
--TM_Plugins
--TM_Plugin1
--Minimap_Title
--Minimap_Window
--TM_Plugin2
--TM_Plugin3
--TM_Plugin4
--TM_Plugin5
--QM_Overlay
---Icons
Hope that's not too confusing.. If it is look at the code.. Load it up in uibuilder to look at the tree with and without the minimap plugin installed..

This needs to be istalled over a fresh install of the main eq2map download to work..

I was thinking of a way to add some kinde of OnEvent code to the above plugin system..

Could add 4 buttons in plugins.xml OnHide OnShow OnMinimize OnRestore..
The OnActivate for them would be..

Parent.Parent.TM_Plugin1.OnEvent.Activated=true
Parent.Parent.TM_Plugin2.OnEvent.Activated=true
Parent.Parent.TM_Plugin3.OnEvent.Activated=true
Parent.Parent.TM_Plugin4.OnEvent.Activated=true
Parent.Parent.TM_Plugin5.OnEvent.Activated=true
Activated=false

Don't have to add anything to any of the blank plugins..


If a modder wanted something to happen when the window minimizes: he/she would add a button to the plugin page called OnMinimize.. Then set the OnActivate script to get something to useful and ending it with Activated=false

For Instance:
I want to add a minimize button to the minimap that presses the mainwindows minimize..
Right now that won't work because my windows cover the titlebar.. But if I had the on events I could save the visible state of my title bar on minimize..

Then in OnRestore I use that visible state to press(or not press) my DockButton to change the window back to its minimap state

I will sleep on it aand work on adding it tomorrow night..

Forgot to mention the OnHide of the main map window would call the OnHide button.. The OnShow would be called in the final version OnShow.. Restore and Minimize in the Onactivate events of those buttons in the title bar :)

Ok, I finally figured out what you were talking about with OnActivate. I had never worked with that OnEvent, but I see how you're using it to basically press other buttons. I'm a little perplexed why you want to though. Like the close button; if you have another button sending a message to the close button... why not just make your button Visible=false the main Map page itself? Also, does OnActivate work in place of OnPress or along side it? Like, could a button have OnActivate and OnPress and they'd both work?

I understand what you're wanting with the minimizing, but wouldn't it be easier to have your own minimize button that performs its own actions?

I understand the includes within an included XML thing perfectly; don't worry about there being any confusion there, but why bother with including the 5 plugin XMLs in a child XML? It'd be more efficient to just include them all in the parent XML and make all the calls direcly from the main OnEvents.

Splitting up the mapborder is gonna have to be a no. Layering the border on top of the MapPage does this ugly thing of putting the tabs behind it at all times, so the current active tab isn't over it. Can't you just make a new border to go over the map when in MiniMap mode? Plus the mapborder was all combined in a previous request, so splitting it up again would be working backwards.

The plugin system (rather, just adding a handful of plugin slots) is a good idea. Using OnActivate to pass OnEvents along is brilliant (wish I had know about that, I've been using OnShow/OnHide).

Quib

Wow I just re-read all my post.. I wanted to say.. I'm still going through all this in my head (and in code).. That's probably why my post(thoughts) are all over the place..
Sorry if I try to over explain some things or don't explain other things.. The things I explain are probably on my mind at the time and it helps me think..

Everything I ask for is just asking.. So if something cannont change I understand that :)

--------------------------------------------------------------------------

Goal:
I'm trying to make the plugin system as modular as possible..
So that plugin system itself is seperate from the mainhud_map as much as possible.. But allows plugins to be very robust & flexible.. (Add buttons, pages, onshow options, etc)

Goal:
I want to make it so no plugin makers cut functionality out of the default coding (or a skins coding).. However, they will be able to add to the end of them, because, the callback events..

Goal:
There should be a callback system for OnTitlebar, OnFrame, OnHide, OnShow, OnMinimize, OnRestore..

Goal:
I want to get the changes in the map system down to 2 includes and a handful of lines of script in the mainhud_map..

--------------------------------------------------------------------------

Right now the way it's set up I can make plugins.xml a blank page and the plugin system is basically removed.. I want it so the whole system can be unplugged. If you change something in the mainhud_map it sits in it shouldn't break the plugin system.. Unless you remove the includes and the script support..

There are 2 reasons for me wanting to change your buttons like that.
1. I want the minimize feature to be a standard feature of eq2map..
2. I DON'T want a modder to write there own (No reason to repeat a function) they should be able write a button that calls your fuction and add to it with the "callback event" that is called..

You would have to use on activate for all buttons you want to call in script If I recall correctly. But not 100% positive.. I came up with that Idea, tested and started using OnActivate in most of my buttons for a while..

I believe:
The OnPress event is only called when the user presses the button in game.. And, not when I activate it through a script call..
OnActivate is also called when the user presses the button in game..

It's pretty much the same technique as hide/show but you can also activate with mouse..



You don't have to change The MapBorder at all.. Just give me the map underlay and it can be a blank page and hidden in the default setup.. I can't add this through a plugin because the plugins should sit on top of everything else, a tan backdrop over the map and poi's is useless.. I don't think it should be named Window_MapUnderlay then.. It should be TM_Plugins_MapUnderlay or something.. I will think of a way to change it..




I want atleast the plugins.xml to use the includes in this way.. Doing it that way makes it very robust/flexible.. Doing the minimap that way demonstrates how robust/flexible it is (I can add a whole bunch of pages right to the main map page if needed).. I can probably contain the whole minimap in one window but It actually makes the script longer in my opinion (more typing anyway).. I don't think it's any less efficient just more flexible..

If I put all the plugin# pages inside the plugins page then I add the pages I need for the minimap and the dock button to a plugin# page.. to access the MapPage from the minimap window for example I would have to type in script..

Parent.Parent.Parent.MapPage.Visible=true
The way it is now I can just do:
Parent.MapPage.Visible=true



Deathbane:
Did I offend you or something in my last reply to you? If I did I'm sorry.. I did not mean too.. I was trying to reinforce your statement not trying to be a Smarta$$, which it kinda came off as.. Haven't heard from ya since then on this subject.. Any thoughts on the subject?



Edit: I'll work on it some more a little later tonight.

Alright, I'll script the Close and Minimize buttons using OnActivate; please suggest some code for the default Minimize button(well, buttons since it's 2). I have a good idea of what I'd do with it, but want your feedback.

Why do you need an underlay? Couldn't your script just use the stuff inside of MapBorder to make an underlay (by moving/resizing it)?

Explain what you mean by OnTitlebar and OnFrame.

Not really sure what this was in reply too so I don't understand the exmaple. I know by using includes outside of page objects you'll avoid a level of using Parent.

The reason I say it's inefficient, is you're calling an include which will just call 5 more includes. That's ~16% less efficient than just directly calling the 5 includes. Likewise, calling one parent plugin object that'll call all the plugins themselves (to distribute the OnEvent calls) adds a layer of calls that just doesn't need to be there. I don't mind bulking up the main page objects OnEvents with calls directly to the plugins; the main page's calls are already massive.

Quib

I'm attaching yet another version of this system.. You can view the changes I made to the buttons there.. I will explain the changes I would make/made here..

The changes to the EQ2Map are minimal:
mainhud_map:
Added 3 lines of code..
You can find them by searching for TM_ ..
The code is support for the callback system and the showing of the plugins page..
and the include for plugins.xml...

window_titlebar.xml changes:
All buttons in titlebar: (To make them pressable through script)
Changed OnPress to OnActivate and added the line Activated=false as the last call in the scripts..

RestoreButton: (To support the Plugins OnEvent Callbacks)
Added Parent.Parent.TM_Plugins.OnRestoreWindow.Activated=true to the second to last call in the OnActivate Script..

MinimizeButton: (To support the Plugins OnEvent Callbacks)
Added Parent.Parent.TM_Plugins.OnMinimizeWindow.Activated=true to the second to last call in the OnActivate Script..

CloseButton: (To make it always close the window no matter what plugin is installed)
The script looks like this now:
OnActivate="Activated=false Parent.Parent.OnHide=TM_OnHideBackup Parent.Parent.Visible=false Parent.Parent.OnHide=' ' TM_OnHideBackup=Parent.Parent.OnHide"


This is what I ended up doing.. I was overthinking it..

I was going to add Callback events for when the Titlebar or Frame changed it's visible state.. I decided to skip it for now.. If there's ever a need for it.. It can be added later..

Sorry I think I read your reply wrong just ignore it..

I thought about it and have come to the conclusion it doesn't matter where the pages go or get included.. As long as they get in there.. I guess either way is just as flexible.. In the new version I got going all the plugins are children of that master page.. The master page takes care of all the callbacks to the plugins.. The main map code just has to perform callbacks on one page that way.. All of this is for the sake of modularity. Seperates it as much as possible..

It's up to you if you want to bulk up the OnEvents code.. I perfer seperating it the way I have it now though..

I included the minimap and 3 other plugins in the zip as examples.. The minimap is now contained in one page.. But, I still have it seperated into 3 files.. The minimap plugin uses the OnRestoreWindow and OnMinimizeWindow events.. the Minimize/Restore with keyboard plugin uses the OnHideWindow callback event.. The other two use the OnShow event to make a change to the map (like the current plugin system)

Edit: Updated Attachment.. made a quick change:
Note: This should be installed over the same eq2map version I've been using for all attachments thus far.
Edit: Updated Attachment again the min/restore with keyboard plugin wasn't working right..

I thought of at least on use for titlebar callbacks in plugins.. It allows modders to hide and show a button plugin (like the dockbutton in minimap) with the titlebar..

So I added both just in case..

Changes to mainhud_map:
I removed the WC_Frame.OnHide=' ' that was in the onshow2 script..

Changes to window_titlebar: OnHide="Parent.TM_Plugins.OnHideTitlebar.Activated=true Parent.Size=484,597" (Read edit at bottom)

OnShow="Parent.TM_Plugins.OnShowTitlebar.Activated=true">

Changes to window_frame:
OnHide="Parent.TM_Plugins.OnHideFrame.Activated=true" OnShow="Parent.TM_Plugins.OnShowFrame.Activated=true"

Plus the changes from previous post

Edit: there was a bug with the titlebar OnHide script.. When the title bar was hidden the window was restored by resizing back to fullsize.. It didn't notify the plugin system.. I changed it so it activates the restore button instead..

So the titlebar on hide should be:
OnHide="Parent.TM_Plugins.OnHideTitlebar.Activated=true QM_RestoreButton.Activated=true"

( I updated the attachment to reflect changes )

Our mods so cool that theres a plugin system....wow...

Ok one last version..

I polished up the minimap..

I made 1 plugin that handles, I think, all the "window options" thus far.. Except the remove fog thingie.. and it adds a few.. Allows you to change upto 4 of the default eq2map behaviours by copying files..

Full-list: (Besides default options and plugins from the old sytem)
CloseOptions:
Min/Restore with keyboard 'M key' Esc disabled

IconOptions:
Alway 50% transparent
33% transparent till mouseover

ConnectionsOptions:
Both Off on login
City Off on login

And my darkness filter:
Maps 15% Darker than default (this is the one I will be using)
Maps 30% Darker than default

The only change to eq2ui_mainhud_map.xml this time was:
I added a page above the WorldMap Image definition..
<Page AbsorbsInput="false" BackgroundColor="#FFFFFF" BackgroundOpacity="1.000" BackgroundTint="#000000" Location="1,2" Name="TM_DarknessOverlay" Opacity="0.000" ScrollExtent="436,506" Size="436,506"/>

Required for my darkness option :D

I also changed the plugins.xml so that all the event buttons are not visible..

Things we will have to note to window skinners if this system is used: (I'm sure you know)
The OnHide and OnShow event for the window frame and title bar have to call the plugin handlers that are present there in the default skin at the end of the event..

The Restore and Minimize OnActivate script must end with the plugin handler followed by Activated=false

The CloseButton OnActivate must end with Ativated=false

Edit: I reversed the order in which the callbacks in plugins.xml get called instead of 1 to 5 the now trigger backwards.. So that plugin 1 has priority over 5.. System now has priorty like the z order of the plugin windows..
This is something to tell to plugin authors

I think that's it from me.. I'm out of ideas for improvements to it..

I was submitting a bug report last night (heh..) when it hit me.. POI!

When the bug report window is up, and your entering your message, you cannot press TAB to go from field to field. It just changes your target which is reflected on the bug report. That is when the idea hit me...

Why not have a pop-out pane in EQ2Map that the user can stand in a spot, target a critter, enter a blurb, click a button and have it send it to our website for POI insertion?

What do ya think?

i will look into making a page that works with the html viewer in game where people can submit new poi's no promises though, because i remember someone said that the thing sucks pretty bad as far as displaying stuff.

Alright, I think everything's looking good so will have a new version of eq2ui_mainhud_map.xml up for the auto-updater to grab by the end of the day. Dolby added a new "allow addons or whatever" option for mods, and I already turned it on for EQ2MAP (the main XML download) so you can upload the plugins there, though I suggest waiting a couple days; I'll update the main download with the newest version the auto-updater downloads after I update the auto-updater's downloadable files.

Quib

Sorry, I got tied up this weekend. Just logged in for my final test of EQ2MAP with your plugin code added. You'll want to get the auto-updater Talyns, and put it in an empty folder and run it to make sure you get all of the newest files. Check eq2ui_mainhud_map.xml, window_plugins.xml (this was the only filename I changed) and everything to make sure what I've done with your work is acceptable. Very little should be different; however I added it to my newest version by hand so you might wanna make sure I didn't miss anything.

Also, I figured out the difference between OnActivate and OnPress (if you already knew this, oh well): OnActivate occurs on mousedown, OnPress occurs on mouseup; basically, I can click and hold on a button, but OnPress won't occur unless my mouse is still over the button when I let go of the mouse button. OnActivate occurs the instant you click on a button. If you used both OnActivate and OnPress on the same button, there's no guarantee OnPress would get called; the user could move the mouse off of the button before releasing.

Quib

No need to apologize..

Looks and works right =)

I found a couple minor things I need to tweak on the Minimap Plugin then I will upload both as add-ons..

Where should I upload them to when I'm done? The map AutoUpdater download? Never mind I reread two post up ;)

I knew OnActivate is called on mouse down.. I think it occurs at the same time the image switches to the "Pressed" Image..

OnDeactivate.. I think is called when the image is changed back to normal..

It's good to know that OnPress has a "user failsafe" to it..
I wonder what's called first OnDeactivate or OnPress.. Good to know how this stuffs works in general..
Hmm... Is it bad that we're going around it? I don't think so.. They're just basic switches..

Probably not a good Idea to put script in OnActivate that could create a bad out come.. Like an autoattack button.. Don't want to accidently attack a sentry or something..

Anyhow, Thanks for adding this feature!

So, When you gonna make that map selector tab plugin? :D